On Feb 5, 2015, at 1:48 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote:
> Hey Sebastien - I merged it only after Erik fixed the DateTime issue > using Joda. Changes look good to me so I did not wait for TravisCI. I love you man, but I think that's bad practice :) We should always wait for TravisCI to finish, even for a typo. but yes mea culpa, I did not see Erik's update. > > > On Thursday 05 February 2015 06:01 PM, sebgoa wrote: >> >> On Feb 5, 2015, at 1:26 PM, Erik Weber <terbol...@gmail.com> wrote: >> >>> I did update it Sebastien :-) >>> >> >> Ah my bad then (cc @Rohit), I did not see a conversation update about it. >> >> all is good then :) >> >>> -- >>> Erik >>> >>> On Thu, Feb 5, 2015 at 1:16 PM, sebgoa <run...@gmail.com> wrote: >>> >>>> Rohit, check the review, Rajani made a suggestion and Terbolous is going >>>> to change his commit. >>>> Please revert and let's wait for an updated commit. >>>> >>>> >>>> On Feb 5, 2015, at 12:54 PM, bhaisaab <g...@git.apache.org> wrote: >>>> >>>>> Github user bhaisaab commented on the pull request: >>>>> >>>>> https://github.com/apache/cloudstack/pull/71#issuecomment-73034891 >>>>> >>>>> Applied on both 4.5 and master. Thanks for fixing this @terbolous ! >>>>> >>>>> >>>>> --- >>>>> If your project is set up for it, you can reply to this email and have >>>> your >>>>> reply appear on GitHub as well. If your project does not have this >>>> feature >>>>> enabled and wishes so, or if the feature is enabled but not working, >>>> please >>>>> contact infrastructure at infrastruct...@apache.org or file a JIRA >>>> ticket >>>>> with INFRA. >>>>> --- >>>> >>>> >> > > -- > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +91 8826230892 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > PS. If you see any footer below, I did not add it :) > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Software > Engineering<http://shapeblue.com/cloudstack-software-engineering/> > CloudStack Infrastructure > Support<http://shapeblue.com/cloudstack-infrastructure-support/> > CloudStack Bootcamp Training > Courses<http://shapeblue.com/cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based upon > its contents, nor copy or show it to anyone. Please contact the sender if you > believe you have received this email in error. Shape Blue Ltd is a company > incorporated in England & Wales. ShapeBlue Services India LLP is a company > incorporated in India and is operated under license from Shape Blue Ltd. > Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is > operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company > registered by The Republic of South Africa and is traded under license from > Shape Blue Ltd. ShapeBlue is a registered trademark.
