Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/94#discussion_r25770875
--- Diff:
api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
---
@@ -111,7 +111,7 @@
@Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from")
private List<String> cidrlist;
- @Parameter(name = ApiConstants.OPEN_FIREWALL, type =
CommandType.BOOLEAN, description = "if true, firewall rule for source/end pubic
port is automatically created; "
+ @Parameter(name = ApiConstants.OPEN_FIREWALL, type =
CommandType.BOOLEAN, description = "if true, firewall rule for source/end
public port is automatically created; "
+ "if false - firewall rule has to be created explicitely. If not
specified 1) defaulted to false when PF"
--- End diff --
actually, there is another one here 'explicitly' can you patch and squash ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
