Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78217077
@vincentbernat thanks for the snippets!
@resmo in case the passwdsrvrtoken went missing (file does not exist), the
script may break, the || true is just so that it return 0 (exit 0). I guess
your snippet is correct as well (check and cat file), using that approach.
@pdion891 looking at the code at least on the VR side there is no password
expiry period imposed by the server. I can sort of understand this, because
someone could shutdown a server, do a reset password and if the VM won't get
started we should store the password in the VR. But let's discuss the security
aspects on what/how we should implement a self expiring cache. I propose:
1. if we have served the password at least once, let's expire it in 15-30
minutes
2. else, expire all the passwords in next 1-24 hours whether they have been
served to user VMs (for resetting purposes) or not.
Comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
