> -----Original Message----- > From: sebgoa [mailto:run...@gmail.com] > Sent: Saturday, April 4, 2015 1:18 PM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] Stop using Review Board > > > On Apr 3, 2015, at 11:36 PM, David Nalley <da...@gnsa.us> wrote: > > > On Fri, Apr 3, 2015 at 9:53 AM, Sateesh Chodapuneedi > > <sateesh.chodapune...@citrix.com> wrote: > >>> -----Original Message----- > >>> From: Sebastien Goasguen [mailto:run...@gmail.com] > >>> Sent: Friday, April 3, 2015 1:57 PM > >>> To: dev@cloudstack.apache.org > >>> Subject: Re: [DISCUSS] Stop using Review Board > >>> > >>> Seems with have lazy consensus. > >>> > >>> Will Stevens contributed CONTRIBUTING instructions at: > >>> https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md > >>> > >>> I am pushing that to 4.5,4.4 and 4.3 and I will update our website > >>> contribution page, removing reference to RB. > >>> I will then put a message in the RB current reviews. > >>> > >>> I propose to leave it a week with the message, this will give time > >>> to folks to move their review to GH. > >>> > >>> After that, I will ask ASF infra to "hide" RB. They cannot make it > >>> readonly, we can only hide the view. > >> > >> If RB is hidden, does that block us from seeing reviews of old patches on > >> it? > >> Some of the commits doesn't have much meat in commit message, and in > such cases used to go back to RB where we could get some information seeing > review history/comments. > >> > > > > All comments were copied to the mailing list. > > > > --David > > I see your point Sateesh, but David is correct *you can search the mail > archive) > and I also see no difference with normal commits made by committers. If the > commit message is bad then tough luck.
Yeah, that helps. Thanks Sebastien, David. Would go through markmail list to dig more. Regards, Sateesh > > At least git blame tells you who changed the file the latest etc....and you > can > always contact the committer who reviewed and applied that patch and should > be familiar with it since he/she agreed to it. > > >
