Github user rsafonseca commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/308#discussion_r31084802
  
    --- Diff: ui/scripts/cloudStack.js ---
    @@ -329,7 +325,6 @@
                             g_regionsecondaryenabled = null;
                             g_loginCmdText = null;
                             
    -                        $.cookie('JSESSIONID', null);
                             $.cookie('sessionkey', null);
    --- End diff --
    
    Indeed Erik, thanks for pointing that out. I've updated the PR.
    
    On Tue, May 26, 2015 at 11:46 PM, Erik Weber <notificati...@github.com>
    wrote:
    
    > In ui/scripts/cloudStack.js
    > <https://github.com/apache/cloudstack/pull/308#discussion_r31083230>:
    >
    > > @@ -329,7 +325,6 @@
    > >                          g_regionsecondaryenabled = null;
    > >                          g_loginCmdText = null;
    > >
    > > -                        $.cookie('JSESSIONID', null);
    > >                          $.cookie('sessionkey', null);
    >
    > I'm no UI/Javascript expert, but should these include hostname as well? If
    > so, same goes for L351+
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/308/files#r31083230>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to