GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/414
Fix 2 findbugs ClassCastExceptions
getDetails() isn't called anywhere in the code, either way, implementation
is wrong since details is a Map\<String, String\> and not a Map\<String,
Map\<String,String\>\>
If this piece of could would get run, it would just fail trying to cast
String to HashMap\<String,String\>
Removed nonsense comment about casting a Collection to a Map obviously
giving exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack findbugs31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #414
----
commit 614821fe1a90a599bc5015a4231b2085942df4f3
Author: Rafael da Fonseca <[email protected]>
Date: 2015-06-14T13:33:50Z
Fix 2 findbugs ClassCastExceptions
getDetails() isn't called anywhere in the code, either way, implementation
is wrong since details is a Map\<String, String\> and not a Map\<String,
Map\<String,String\>\>
If this piece of could would get run, it would just fail trying to cast
String to HashMap\<String,String\>
Removed nonsense comment about casting a Collection to a Map obviously
giving exception
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
