Thanks for picking this up! LGTM, I'll try to test it tomorrow.
One comment: I'd propose the setting name to reflect 'out of band'. Now it looks like when you migrate a router in ACS it will also reboot. router.reboot.when.outofband.migrated? Regards, Remi Sent from my iPhone > On 16 Jun w2015, at 17:20, DaanHoogland <g...@git.apache.org> wrote: > > GitHub user DaanHoogland opened a pull request: > > https://github.com/apache/cloudstack/pull/466 > > CLOUDSTACK-8545 make reboot on out of band migration configurable > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/DaanHoogland/cloudstack 4.4 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/cloudstack/pull/466.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #466 > > ---- > commit 68a4d5f9d457734279a987e028690d72b2815439 > Author: Daan Hoogland <daan.hoogl...@gmail.com> > Date: 2015-06-16T15:12:43Z > > CLOUDSTACK-8545 make reboot on out of band migration configurable > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > ---
