Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/467#discussion_r32616885
  
    --- Diff: utils/src/com/cloud/utils/StringUtils.java ---
    @@ -32,6 +33,21 @@
     public class StringUtils {
         private static final char[] hexChar = {'0', '1', '2', '3', '4', '5', 
'6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'};
     
    +    private static Charset _ACS_Charset;
    +
    +    {
    +        String preferredCharset = "UTF8";
    --- End diff --
    
    so are so absolutely right. My code would silently fall back to that as it 
is the default if file.encoding is not set. bad bug, will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to