IMO, asserts should be completely removed in most classes. It's mostly used in early development stages and ACS has been production grade for quite some time. The assert statement won't even run on production, because it's disabled by default in the JVM in production runtime, and we're of course not enabling those when JVM starts... even if we did, it would just kill the JVM, which is only something useful in very limited scenarios, which is not the case for ACS.. proper way is always check and properly handle, not throw an assert that would kill the JVM. Just my .02c
On Tue, Jun 23, 2015 at 10:41 PM, asfbot <notificati...@github.com> wrote: > cloudstack-pull-requests #635 > <https://builds.apache.org/job/cloudstack-pull-requests/635/> SUCCESS > This pull request looks good > > — > Reply to this email directly or view it on GitHub > <https://github.com/apache/cloudstack/pull/515#issuecomment-114635372>. >
