Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/558#discussion_r34126781
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -407,10 +410,10 @@ def fw_vpcrouter(self):
                                 ])
     
             if self.get_type() in ["public"]:
    -            self.fw.append(["nat", "front",
    -                            "-A POSTROUTING -o %s -j SNAT --to-source %s" %
    -                           (self.dev, self.address['public_ip'])
    -                            ])
    +            # self.fw.append(["nat", "front",
    --- End diff --
    
    The idea is to get his PR merged, then I will apply the fixes, remove the 
commented lines, test and create a new PR.
    
    No, the changes above won't break any existing tests. The redundant VPC has 
just 1 test till now, which tests the offering and creation of rVPC - it was 
added by @afornie. @isoutham is adding the second test from scratch, so that 
won't break anything.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to