I have started working on this in [1] and found that a lot of this is in the upgrade code. I fixed a few of those and all of them in other code. I will triage the upgrade issues separately and like to have a review on [1] now, please.
[1] https://github.com/apache/cloudstack/pull/564 On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi <raj...@apache.org> wrote: > This not a good candidate for squashing/huge commit. > If a regression is found in any of the fixes, it will be easier to just > revert it than reverting all the 70 commits. > > ~Rajani > > On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav <rohit.ya...@shapeblue.com> > wrote: > >> >> On 07-Jul-2015, at 3:40 pm, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >> >> I will not do it in one commit, if we insist on a PR i will do 73 commits >> in one PR. >> >> >> Fine. >> >> Regards, >> Rohit Yadav >> Software Architect, ShapeBlue >> >> >> >> >> M. +91 88 262 30892 | rohit.ya...@shapeblue.com >> Blog: bhaisaab.org | Twitter: @_bhaisaab >> >> >> >> >> Find out more about ShapeBlue and our range of CloudStack related services >> >> IaaS Cloud Design & Build >> <http://shapeblue.com/iaas-cloud-design-and-build//> >> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/> >> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/> >> CloudStack Software Engineering >> <http://shapeblue.com/cloudstack-software-engineering/> >> CloudStack Infrastructure Support >> <http://shapeblue.com/cloudstack-infrastructure-support/> >> CloudStack Bootcamp Training Courses >> <http://shapeblue.com/cloudstack-training/> >> >> This email and any attachments to it may be confidential and are intended >> solely for the use of the individual to whom it is addressed. Any views or >> opinions expressed are solely those of the author and do not necessarily >> represent those of Shape Blue Ltd or related companies. If you are not the >> intended recipient of this email, you must neither take any action based >> upon its contents, nor copy or show it to anyone. Please contact the sender >> if you believe you have received this email in error. Shape Blue Ltd is a >> company incorporated in England & Wales. ShapeBlue Services India LLP is a >> company incorporated in India and is operated under license from Shape Blue >> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil >> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is >> a company registered by The Republic of South Africa and is traded under >> license from Shape Blue Ltd. ShapeBlue is a registered trademark. >> -- Daan
