Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan.
3 new defect(s) introduced to cloudstack found with Coverity Scan. 32 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java: 5378 in com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.AttachConfigDriveToMigratedVm(com.xensource.xenapi.Connection, java.lang.String, java.lang.String)() ________________________________________________________________________________________________________ *** CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java: 5378 in com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.AttachConfigDriveToMigratedVm(com.xensource.xenapi.Connection, java.lang.String, java.lang.String)() 5372 break; 5373 5374 } 5375 5376 return true; 5377 >>> CID 1311706: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) >>> Catching RuntimeExceptions, perhaps unintentionally, with a catch block >>> for Exception 5378 }catch (Exception ex) { 5379 s_logger.debug("Failed to attach config drive ISO to the VM "+ vmName + " In host " + ipAddr ); 5380 return false; 5381 } 5382 5383 } 5384 ** CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /framework/db/src/com/cloud/utils/db/SequenceFetcher.java: 159 in com.cloud.utils.db.SequenceFetcher$Fetcher.call()() ________________________________________________________________________________________________________ *** CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /framework/db/src/com/cloud/utils/db/SequenceFetcher.java: 159 in com.cloud.utils.db.SequenceFetcher$Fetcher.call()() 153 txn.commit(); 154 return (T)obj; 155 } catch (SQLException e) { 156 s_logger.warn("Caught this exception when running: " + (updateStmt != null ? updateStmt.toString() : ""), e); 157 } 158 } >>> CID 1311707: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) >>> Catching RuntimeExceptions, perhaps unintentionally, with a catch block >>> for Exception 159 } catch (Exception e) { 160 s_logger.warn("Caught this exception when running.", e); 161 } 162 return null; 163 } 164 } ** CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java: 661 in com.cloud.vm.dao.UserVmDaoImpl.getVmsDetailByNames(java.util.Set, java.lang.String)() ________________________________________________________________________________________________________ *** CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) /engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java: 661 in com.cloud.vm.dao.UserVmDaoImpl.getVmsDetailByNames(java.util.Set, java.lang.String)() 655 new Pair<Long, String>(rs.getLong("vm_instance.id"), rs.getString("user_vm_details.value")))); 656 } 657 } catch (Exception e) { 658 s_logger.error("GetVmsDetailsByNames: Exception: " + e.getMessage()); 659 throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage()); 660 } >>> CID 1311708: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) >>> Catching RuntimeExceptions, perhaps unintentionally, with a catch block >>> for Exception 661 } catch (Exception e) { 662 s_logger.error("GetVmsDetailsByNames: Exception in sql: " + e.getMessage()); 663 throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage()); 664 } 665 666 return vmsDetailByNames; 667 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/943?tab=overview To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", click https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231