[GitHub] cloudstack pull request: Dereference NULL return value

[kansal]

Github user kansal commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/618#discussion_r35524889
  
    --- Diff: 
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
 ---
    @@ -119,12 +123,12 @@
         @Override
         public boolean start() {
             if (isSAMLPluginEnabled()) {
    -            setup();
                 s_logger.info("SAML auth plugin loaded");
    +            return setup();
             } else {
    --- End diff --
    
    @bhaisaab I feel we can go with the if-else style because it anyhow is 
doing the same thing plus it give better code readability and logging. Your 
take?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---