Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/626#issuecomment-125522926
LGTM
The thing with the line number could be done in a different PR.
Cheers,
Wilder
Sent from my iPhone
On 28 Jul 2015, at 04:38, Pierrre-Luc Dion
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
* build .deb package job must be change for dpkg-buildpackage -uc -us
ubuntu 14.04 enforce signature of package. CLOUDSTACK-8638
* @wilderrodrigues<https://github.com/wilderrodrigues>: this fix
dependency for keepalived on building systemvm64template. Changing libnl1 by
libnl-3-200 libnl-genl-3-200 seams resolve the build problem.
For unknown reason the default way to retrieve version mvn
org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate
-Dexpression=project.version | grep -v "\[" does not work in package creation,
it return a null value.
________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/apache/cloudstack/pull/626
Commit Summary
* fix dependency for keepalived from wheezy-backports
* fix release version automatically updated using pom.xml
* change last owner of change for pgp signature
File Changes
* M
debian/changelog<https://github.com/apache/cloudstack/pull/626/files#diff-0> (2)
* M
debian/rules<https://github.com/apache/cloudstack/pull/626/files#diff-1> (2)
* M
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh<https://github.com/apache/cloudstack/pull/626/files#diff-2>
(2)
Patch Links:
* https://github.com/apache/cloudstack/pull/626.patch
* https://github.com/apache/cloudstack/pull/626.diff
â
Reply to this email directly or view it on
GitHub<https://github.com/apache/cloudstack/pull/626>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
