Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36102819
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String bucke
ListObjectsRequest listObjectsRequest = new
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory +
SEPARATOR);
ObjectListing ol = client.listObjects(listObjectsRequest);
--- End diff --
we don't catch any of the amazon runtime exceptions. I think we should wrap
them in a CloudstackRuntimeException so they can be caught be the servlet
before propagating into the container. This is not in your PR @borisroman so I
won't -1 on it but if you are on it, why not improve ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
