Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-127946635
@devdeep the test you added seems fine and passes (the assert messages look
like they can be better formulated to describe what went wrong)
I do not understand the relevance to these test with respect to the changed
code though.
Don't get me wrong, you wrote a fine set of additional tests and cloudstack
is not an easy book to read so I might be misreading your test. I would like it
to be clear and obvious that the added tests test what has been changed in this
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
