Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/660#issuecomment-128242754
Even after e5ffcab0 and this change, race condition is possible right? Let
us say the hypervisor takes time to attach and another attach command came in
before this is completed.
I think its better to persist the devidceId in the table(will set it back
to null if something fails) as soon as we generate it and also synchronising
the code in getDeviceId() function using GlobalLock
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
