Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515531
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1972,45 +1972,45 @@
}
},
secondaryStorage: {
- fields: {
+ fields: {
provider: {
label: 'label.provider',
select: function(args) {
- var storageproviders = [];
- storageproviders.push({ id: '', description:
''});
-
- $.ajax({
- url: createURL('listImageStores'),
- data: {
- provider: 'S3'
- },
- async: true,
- success: function(json) {
- var s3stores =
json.listimagestoresresponse.imagestore;
- if(s3stores != null &&
s3stores.length > 0) {
- storageproviders.push({
id: 'S3', description: 'S3'}); //if (region-wide) S3 store exists already, only
"S3" option should be included here. Any other type of store is not allowed to
be created since cloudstack doesn't support multiple types of store at this
point.
- } else {
- /*
- UI no longer gets providers
from "listStorageProviders&type=image" because:
- (1) Not all of returned values
are handled by UI (e.g. Provider "NetApp" is not handled by UI).
- (2) Provider "SMB" which is
handled by UI is not returned from "listStorageProviders&type=image"
- */
- storageproviders.push({
id: 'NFS', description: 'NFS'});
- storageproviders.push({
id: 'SMB', description: 'SMB/CIFS'});
- storageproviders.push({
id: 'S3', description: 'S3'});
- storageproviders.push({
id: 'Swift', description: 'Swift'});
- }
+ var storageproviders = [];
+ storageproviders.push({ id: '', description:
''});
+
+ $.ajax({
+ url: createURL('listImageStores'),
+ data: {
+ provider: 'S3'
+ },
+ async: true,
+ success: function(json) {
+ var s3stores =
json.listimagestoresresponse.imagestore;
+ if(s3stores != null && s3stores.length
> 0) {
+ storageproviders.push({ id: 'S3',
description: 'S3'}); //if (region-wide) S3 store exists already, only "S3"
option should be included here. Any other type of store is not allowed to be
created since cloudstack doesn't support multiple types of store at this point.
+ } else {
+ /*
+ UI no longer gets providers from
"listStorageProviders&type=image" because:
+ (1) Not all of returned values are
handled by UI (e.g. Provider "NetApp" is not handled by UI).
+ (2) Provider "SMB" which is
handled by UI is not returned from "listStorageProviders&type=image"
+ */
--- End diff --
remove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
