Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132654938
@DaanHoogland I agree with your considerations. My first commit was not
performed properly. Sadly, the eclipse ended up formatting classes I touched,
and that is why the line number added was higher than the removed one.
I do understand that âs_ somethingâ is a proper way to instantiate a
static variable in ACS classes. However, in few of the subclasses of
âcom.cloud.utils.component.ComponentLifecycleBaseâ it was used names such
as âLOGGERâ (that is a proper name for static field as JAVA standards),
log, status_logger and others.
What we propose is to change the logger variable in
âcom.cloud.utils.component.ComponentLifecycleBaseâ to protected and remove
its static and final declaration. Therefore we did the following in
ComponentLifecycleBase:
protected Logger logger = Logger.getLogger(getClass());
This way, every single subclass of ComponentLifecycleBase, when
instantiated would automatically have a logger instance for its proper class
ready to be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
