Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/732#discussion_r37854560
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java 
---
    @@ -31,25 +31,36 @@
     import org.apache.cloudstack.api.response.SnapshotResponse;
     import org.apache.cloudstack.api.response.SuccessResponse;
     import org.apache.cloudstack.context.CallContext;
    +import org.apache.log4j.Logger;
     
     import com.cloud.event.EventTypes;
     import com.cloud.storage.Snapshot;
     import com.cloud.user.Account;
     
    -@APICommand(name = "revertSnapshot", description = "revert a volume 
snapshot.", responseObject = SnapshotResponse.class, entityType = 
{Snapshot.class},
    +@APICommand(name = "revertSnapshot", description = "revert a volume 
snapshot.", responseObject = SuccessResponse.class, entityType = 
{Snapshot.class},
    --- End diff --
    
    I think for API backward compatibility, please revert this to send 
SnapshotResponse as the responseobject, unless this really needs to be fixed 
(the older implementation got it wrong). Please comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to