Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37947073
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilder.java
---
@@ -0,0 +1,62 @@
+//Licensed to the Apache Software Foundation (ASF) under one
+//or more contributor license agreements. See the NOTICE file
+//distributed with this work for additional information
+//regarding copyright ownership. The ASF licenses this file
+//to you under the Apache License, Version 2.0 (the
+//"License"); you may not use this file except in compliance
+//with the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+//Unless required by applicable law or agreed to in writing,
+//software distributed under the License is distributed on an
+//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+//KIND, either express or implied. See the License for the
+//specific language governing permissions and limitations
+//under the License.
+package org.apache.cloudstack.api.response;
+
+
+import org.apache.cloudstack.api.command.QuotaBalanceCmd;
+import org.apache.cloudstack.api.command.QuotaEmailTemplateListCmd;
+import org.apache.cloudstack.api.command.QuotaEmailTemplateUpdateCmd;
+import org.apache.cloudstack.api.command.QuotaStatementCmd;
+import org.apache.cloudstack.api.command.QuotaTariffListCmd;
+import org.apache.cloudstack.api.command.QuotaTariffUpdateCmd;
+import org.apache.cloudstack.quota.vo.QuotaBalanceVO;
+import org.apache.cloudstack.quota.vo.QuotaTariffVO;
+import org.apache.cloudstack.quota.vo.QuotaUsageVO;
+
+import java.util.Date;
+import java.util.List;
+
+public interface QuotaResponseBuilder {
+
+ QuotaTariffVO updateQuotaTariffPlan(QuotaTariffUpdateCmd cmd);
+
+ List<QuotaTariffVO> listQuotaTariffPlans(QuotaTariffListCmd cmd);
+
+ QuotaTariffResponse createQuotaTariffResponse(QuotaTariffVO
configuration);
+
+ QuotaStatementResponse createQuotaStatementResponse(List<QuotaUsageVO>
quotaUsage);
+
+ QuotaBalanceResponse createQuotaBalanceResponse(List<QuotaBalanceVO>
quotaUsage, Date startDate, Date endDate);
+
+ QuotaBalanceResponse
createQuotaLastBalanceResponse(List<QuotaBalanceVO> quotaBalance, Date
startDate);
+
+ QuotaCreditsResponse addQuotaCredits(Long accountId, Long domainId,
Double amount, Long updatedBy, Date despositedOn);
+
+ public List<QuotaUsageVO> getQuotaUsage(QuotaStatementCmd cmd);
--- End diff --
The accessor modifier is unnecessary on an interface definition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
