Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38727056
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String password, Long domain
if (domain != null) {
domainName = domain.getName();
}
+ userAccount = _userAccountDao.getUserAccount(username,
domainId);
--- End diff --
For now this is not an issue as every authenticator checks for the presence
of user account. But the code flow of getUserAccount() method doesn't clearly
brings it up. Earlier since there was a check for user account at the beginning
it was very explicit. Now there is an implicit assumption that authenticator
should return failure if the user account is not present in CCP. Please file a
tracking bug for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
