Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140729409
Dear @wilderrodrigues, As I said I get your point and the moment that you
guys are on closing a version.
A mistake was made, the moment I noticed that I jumped in and checked the
problem and tried to fix it with this PR. No need to cut someoneâs head with
adamantium claws.
Sure the task was huge, but simple. That was the point on giving it to a
less experienced student. I want them to see that even in huge systems like
CloudStack and others; there are codes that are not pretty and shiny.
The improvement factor depends on the concept you use, removing few lines
of code and using a more intuitive and standard name for a variable in a
hierarchic of classes can be considered an improvement. The same occur if we
remove the @Local annotation of that hierarchic, the task will affect 600+
classes, but it is a simple one.
Since you said that there is no way this PR will get accepted, I am closing
it.
Thanks for your time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
