Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/828#discussion_r39824131
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
vmConfig.setGuestId(guestOsIdentifier);
}
+ public static void addUSBController(VirtualMachineConfigSpec
vmConfigSpec) {
--- End diff --
@sureshanaparti if other methods are like and you're simply follow those
conventions, then it's fine though it becomes easier to test methods
functionally if they return objects instead of modifying them. In either case,
can you add a simple unit test for this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
