Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/799#issuecomment-141945369
@bhaisaab For CentOS 7 we have we cloud-management.service and
cloud-management.config files. I don't see any other .rc file for
cloud-management service.
cloud-management.service
[Unit]
Description=CloudStack Management Server
After=syslog.target network.target
[Service]
Type=forking
ExecStart=/usr/sbin/tomcat-sysd start
ExecStop=/usr/sbin/tomcat-sysd stop
SuccessExitStatus=143
User=cloud
Group=cloud
EnvironmentFile=/etc/sysconfig/cloudstack-management
[Install]
WantedBy=multi-user.target
cloud-management.config :
# Required for a tocmat cloned service
SERVICE_NAME=cloudstack-management
# Where your java installation lives
#JAVA_HOME="/usr/lib/jvm/java"
@remibergsma
I scanned through the packaging folder and found another instance
(cloud-ipallocator.rc) where the basename is directly used for referring PID
file and fixed the same. Below is the grep result before and after the fix.
Before:
Sudhansus-MAC:packaging sudhansu$ grep 'basename' */*.rc
centos63/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
centos63/cloud-ipallocator.rc:SHORTNAME=`basename $0`
centos63/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
centos7/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
centos7/cloud-ipallocator.rc:SHORTNAME=`basename $0`
fedora20/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
fedora20/cloud-ipallocator.rc:SHORTNAME=`basename $0`
fedora20/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
fedora21/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
fedora21/cloud-ipallocator.rc:SHORTNAME=`basename $0`
fedora21/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
After:
Sudhansus-MAC:packaging sudhansu$ grep 'basename' */*.rc
centos63/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
centos63/cloud-ipallocator.rc:SHORTNAME="$(basename $(readlink -f $0))"
centos63/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
centos7/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
centos7/cloud-ipallocator.rc:SHORTNAME="$(basename $(readlink -f $0))"
fedora20/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
fedora20/cloud-ipallocator.rc:SHORTNAME="$(basename $(readlink -f $0))"
fedora20/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
fedora21/cloud-agent.rc:SHORTNAME=$(basename $0 | sed -e
's/^[SK][0-9][0-9]//')
fedora21/cloud-ipallocator.rc:SHORTNAME="$(basename $(readlink -f $0))"
fedora21/cloud-management.rc:NAME="$(basename $(readlink -f $0))"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
