Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/793#issuecomment-143647389
Rebased the PR to current master.
Regarding unit tests, method doesn't have input or output as a unit. It has
output only in terms of DB updation so for me useful unit tests for these
methods can not be written.
http://www.petrikainulainen.net/programming/testing/writing-tests-for-data-access-code-unit-tests-are-waste/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
