GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/909
CLOUDSTACK-8848
added a null guard to @resmo's #885 A unit test or two would be nice as
well but as this is a blocker I want to get it to review asap.
@koushik-das @wilderrodrigues @anshul1886 @karuturi @remibergsma you all
commented on the original, please have a look. @bhaisaab welcome to comment as
well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack RESMO-CLOUDSTACK-8848
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 542880ae76c5e6eefbf61d42364e881495e6f3af
Author: Rene Moser <[email protected]>
Date: 2015-09-24T19:10:26Z
CLOUDSTACK-8848: ensure power state is up to date when handling missing VMs
in powerReport
There 2 things which has been changed.
* We look on power_state_update_time instead of update_time. Didn't make
sense to me at all to look at update_time.
* Due DB update optimisation, powerState will only be updated if <
MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT. That is why we can not rely on these
information unless we make sure these are up to date.
commit bde803ee98d3f343652a8486c5e5faad74b0ea11
Author: Daan Hoogland <[email protected]>
Date: 2015-10-02T09:42:42Z
CLOUDSTACK-8848: added null pointer guard to new public method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
