Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41807645
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java
---
@@ -21,10 +21,10 @@
public interface NuageVspApiClient {
- public void login() throws Exception;
+ void login() throws Exception;
- public void setNuageVspHost(String restRelativePath, String[]
cmsUserInfo, int noofRetry, int retryInterval);
+ void setNuageVspHost(String restRelativePath, String[] cmsUserInfo,
int noofRetry, int retryInterval, String nuageVspCmsId);
- public String executeRestApi(String method, String resource, String
resourceId, String childResource, Object entityDetails, String resourceFilter,
String proxyUserUuid,
- String proxyUserDomainuuid) throws Exception;
+ String executeRestApi(String method, String resource, String
resourceId, String childResource, Object entityDetails, String resourceFilter,
String proxyUserUuid,
+ String proxyUserDomainuuid) throws
Exception;
--- End diff --
This ``throws`` is too broad. Please enumerate the expected checked
exceptions to be thrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
