Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41981224
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ---
    @@ -114,7 +117,9 @@ public Network design(NetworkOffering offering, 
DeploymentPlan plan, Network use
             PhysicalNetworkVO physnet = 
_physicalNetworkDao.findById(plan.getPhysicalNetworkId());
             DataCenter dc = _dcDao.findById(plan.getDataCenterId());
             if (!canHandle(offering, dc.getNetworkType(), physnet)) {
    -            s_logger.debug("Refusing to design this network");
    +            if (s_logger.isDebugEnabled()) {
    +                s_logger.debug("Refusing to design this network");
    --- End diff --
    
    This is <code>DEBUG</code> logging since core ACS asks our plugin to design 
some network which we do not support, therefore we just log that we are 
refusing it, and just returning <code>NULL</code> which core ACS will handle 
nicely. Added some additional info about the network to be designed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to