Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/935#discussion_r42215621 --- Diff: plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java --- @@ -191,6 +204,19 @@ public PingCommand getCurrentStatus(final long id) { return new PingCommand(Host.Type.L2Networking, id); } + private int searchApiProvider(ClusterRoleConfig[] configuredRoles) { + int length = configuredRoles.length; + for (int i = 0; i < length; i++) { + if (! configuredRoles[i].getRole().equals("api_provider")){ --- End diff -- This conditional could be simplified: ```java if (configuredRoles[i].getRole().equals("api_provider")) { return i } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---