Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43090521
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -129,6 +145,18 @@
AgentManager _agentMgr;
@Inject
NetworkOfferingDao _ntwkOfferingDao;
+ @Inject
+ ConfigurationDao _configDao;
+ @Inject
+ NuageVspManager _nuageVspManager;
+ @Inject
+ FirewallRulesDao _firewallRulesDao;
+ @Inject
+ FirewallRulesCidrsDao _firewallRulesCidrsDao;
+ @Inject
+ PhysicalNetworkDao _physicalNetworkDao;
+ @Inject
+ NetworkACLItemDao _networkACLItemDao;
@Override
public boolean applyIps(Network network, List<? extends
PublicIpAddress> ipAddress, Set<Service> service) throws
ResourceUnavailableException {
--- End diff --
I moved some code here and there, it's shortened now by decomposing into
smaller private methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
