Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43095297
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ---
    @@ -114,7 +115,9 @@ public Network design(NetworkOffering offering, 
DeploymentPlan plan, Network use
             PhysicalNetworkVO physnet = 
_physicalNetworkDao.findById(plan.getPhysicalNetworkId());
             DataCenter dc = _dcDao.findById(plan.getDataCenterId());
             if (!canHandle(offering, dc.getNetworkType(), physnet)) {
    -            s_logger.debug("Refusing to design this network");
    +            if (s_logger.isDebugEnabled()) {
    +                s_logger.debug("Refusing to design network using network 
offering " +  offering.getId() + (physnet != null ? " on physical network " + 
physnet.getId() : ""));
    --- End diff --
    
    Not really, all plugins are logging this as <code>DEBUG</code>. 
    The code that's calling this method is as following
    ```java
                for (final NetworkGuru guru : networkGurus) {
                    final Network network = guru.design(offering, plan, 
predefined, owner);
                    if (network == null) {
                        continue;
                    }
                    ...
                }
    ```
    It's looping over all gurus, we don't want our guru to log it as 
<code>WARN</code> every time a network is created and we don't support it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to