All, +1000 to this idea. bors [1] is an example of this type of system that works well. It provides on-demand build and implements the project’s rules to merge changes to the master/develop branch (e.g. an LGTM from two committers). In addition to enforcing the project’s policies, it ensures that only one PR is merged at time further protecting master if two conflicting PRs are approved in roughly the same timeframe. One of the PRs will loose — forcing a rebase and fix before being merged. Ideally, no one should be hitting the big green button. Can we configure Jenkins to behave in this manner?
Thanks, -John [1]: https://github.com/graydon/bors --- John Burwell (@john_burwell) VP of Software Engineering, ShapeBlue (571) 403-2411 | +44 20 3603 0542 http://www.shapeblue.com | @ShapeBlue 53 Chandos Place, Covent Garden, London, WC2N 4HS > On Oct 30, 2015, at 7:13 AM, Daan Hoogland <[email protected]> wrote: > > So Rajani, you suggest to remove the automatic trigger and leave that to > reviewer. Sound fine to me. > > On Fri, Oct 30, 2015 at 7:35 AM, Rajani Karuturi <[email protected]> wrote: > >> Thats a good idea. I have seen other open source projects do it this way. >> (example: netty project) >> On demand build is a better way than doing for every commit change. >> >> especially when the code reviews are going on or there is WIP, its not >> intended to do a build on every commit or update. (The commit could just be >> a change in commit message) >> >> when the contributor is ready, he can call jenkins to verify it by just >> commenting @jenkins build >> once the code comments(if any) are addressed, we can ask it to build again. >> >> ~Rajani >> >> On Thu, Oct 29, 2015 at 7:41 PM, Remi Bergsma <[email protected] >>> >> wrote: >> >>> Hi all, >>> >>> Just had a chat with Miguel. >>> He showed me that if we setup Github to notify Jenkins on “issue >> comments” >>> (next to “pull requests” we have now) and then set a “trigger phrase” in >>> Jenkins, we could automatically trigger a new build by typing “go build”. >>> No more need to force push commits by the author. >>> >>> Shall we set this up? Can we do this David? >>> >>> Regards, >>> Remi >>> >>> >>> From: Remi Bergsma >>> Date: Thursday 29 October 2015 08:47 >>> To: "[email protected]<mailto:[email protected]>" >>> Subject: Jenkins failures >>> >>> Hi, >>> >>> Can someone please look why Jenkins fails so often recently? It feels >> like >>> a casino and slows down merging of PRs since we want to merge when they >>> “are green”. This requires forse pushing many times now, including the >> wait. >>> >>> I’d prefer not to start ignoring them.. >>> >>> Thanks for the help! >>> >>> Regards, >>> Remi >>> >>> >> > > > > -- > Daan Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
