GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1084
CLOUDSTACK-9067 - As I developer I want to remove all the unused
router-shell scripts from ACS
This PR removes the unused shell scripts that were present in the ACS
project. Those script were replaced by the.
Some of the scripts are used by the HyperV Resource, which were hardcoded.
I took the opportunity to use the Java constants over there as well, so the
next one touching the code will know they exist and won't hardcode anything.
The following task were applied:
* Remove the shell files and the Java constants that were mapping them;
* Apply the use of the Java constants to the HyperV Resource class;
* Wrap the String.format() method in the StringUtils so we can test the
changes in the HyperV Resource class.
The last point was added because I do not have a HyperV test environment.
Hence, I wanted to make sure the tiny code I changed is covered at least by
unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack
improvement/remove_scripts-CLOUDSTACK-9067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1084.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1084
----
commit 6477bd8ff7f982e10d0d20a97857262897dc05ed
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date: 2015-11-17T11:14:56Z
CLOUDSTACK-9067 - Remove old script file from the project
- Java constants also removed
- Project still compiling and all unit tests passing.
commit 1cf57f74d7e59d07a5c003a80b7dcc499dad9be8
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date: 2015-11-17T11:19:52Z
CLOUDSTACK-9067 - Fomatting the code of HypervDirectConnectResource class
commit fdf826c5a139ea70f707f7732d5320e28ec9e704
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date: 2015-11-17T14:01:39Z
CLOUDSTACK-9067 - Add format method to StringUtils class
- String.format() method is being wrapped to ease the tests
- Tests added to cover simple string formatting used for the HyperV
Resource class.
commit 455926907c44193a6f5dd48f0123629e04adf79a
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date: 2015-11-17T14:31:27Z
CLOUDSTACK-9067 - Replace script literal names by constant name.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
