GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1057
Cwe 190 coverity warnings of this type adressed. Some where dismissed and maybe with reason but it seemed possible to remove them and hence obligatory ;p You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CWE-190 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1057.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1057 ---- commit b5625c05d04c7c886192ba9c3e8ed7c0b05ea482 Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-10T13:00:22Z CID-1175714 casts before bit shift commit 637afb9b6740134b70d40ba8df4e93e36ded5b42 Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-10T13:16:49Z CID-1116485: cast cidr during bit shifting and simple test included commit 2fadfe93dcb63693485fb44a7c5146024e232c3c Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-10T13:40:24Z CID-1116484 cast to long and use long as cidrsize type and simpel test commit f9d5c6918cf5f0b7c5524b4c2d421c84f3eb55ab Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-10T13:54:52Z CID-1116483 cidr to netmask bitshifts guarded with casts and simple test commit 3ae4dd06f355ce81da4c672d1305c7707ccc6d8a Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-10T15:18:52Z CID-1116482 cidrToLong cleanup of bitshift problem and some trivial testing commit 1bc837837ff39efc06f687cbb281ce97c08e4aee Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-11T09:05:47Z CWE-190 netmask as long form cidr-size as method commit 02058b939c54be8c088e57dbcc719bcfd5113ff0 Author: Daan Hoogland <d...@onecht.net> Date: 2015-11-11T09:22:04Z CWE-190 unit test for extremes of long netMaskFromCidr(long) ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---