[GitHub] cloudstack pull request: Quota

[remibergsma]

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/768#issuecomment-161449429
  
    Had a first look at the feature and have some questions / remarks:
    
    The quota icon is the only one in color and doesn't really fit the rest. Is 
that done on purpose (color/bigger)?
    
    <img width="257" alt="screen shot 2015-12-02 at 22 52 43" 
src="https://cloud.githubusercontent.com/assets/1630096/11545626/88f626b4-9948-11e5-9ab1-483d5d329938.png";>
    
    Global setting `quota.enable.service` is `false` by default, but then it 
does display in the menu. One assumes it works, but you get errors like this:
    
    <img width="564" alt="screen shot 2015-12-02 at 22 53 10" 
src="https://cloud.githubusercontent.com/assets/1630096/11545666/d3db8e9e-9948-11e5-8297-57910d1b6c15.png";>
    
    Flipping the setting to `true` makes this error go away. Maybe it is better 
to not display anything when the global setting is false? Or at least make 
clear it is not supposed to work.
    
    Setting `quota.currency.symbol` defaults to `R`. Is that a sane default?
    
    Now that the plugin is enabled I get some SQL errors so I probably miss 
some tables or such. I built a new environment from this branch. Tomorrow I'll 
investigate and read some more documentation on what I should to do set this up.
    
    Nice feature, looking forward to try the rest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---