Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1187#discussion_r46935277
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java
---
@@ -106,6 +104,8 @@ private void setupcheckVolumeFileForActivityFile(File
file, long minSize) throws
writer.write(chars);
written += chars.length;
}
+ long creationTime = System.currentTimeMillis();
--- End diff --
Not really, if you move it one line down, after
<code>writer.close()</code>, the test could still give false positives because
there could still be a hickup during <code>writer.close()</code> while the file
has already been written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
