Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1200#discussion_r47093362
--- Diff: core/src/com/cloud/agent/api/RebootCommand.java ---
@@ -19,29 +19,25 @@
package com.cloud.agent.api;
-import com.cloud.vm.VirtualMachine;
-
public class RebootCommand extends Command {
String vmName;
+ protected boolean executeInSequence = false;
protected RebootCommand() {
}
- public RebootCommand(VirtualMachine vm) {
- vmName = vm.getInstanceName();
- }
-
- public RebootCommand(String vmName) {
+ public RebootCommand(String vmName, boolean executeInSequence) {
this.vmName = vmName;
+ this.executeInSequence = executeInSequence;
}
public String getVmName() {
- return vmName;
+ return this.vmName;
}
@Override
public boolean executeInSequence() {
- return true;
+ return this.executeInSequence;
--- End diff --
Why the 'this.' prefix? Although it works I thought it was the general idea
that you should not use it when not needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
