Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1211#issuecomment-164129115
  
    LGTM based on the below test.
    
    Original on current master:
    - create domain, account and login
    - create vpc
    - create acl
    - no option to delete it
    
    <img width="571" alt="screen shot 2015-12-12 at 10 23 15" 
src="https://cloud.githubusercontent.com/assets/1630096/11761241/8142a3ec-a0ba-11e5-9a3d-d1cc13abd531.png";>
    
    The same on this PR:
    <img width="999" alt="screen shot 2015-12-12 at 10 17 57" 
src="https://cloud.githubusercontent.com/assets/1630096/11761242/934f58f0-a0ba-11e5-87d9-61b7f0d3eca9.png";>
    
    Option to delete is now there:
    <img width="577" alt="screen shot 2015-12-12 at 10 18 09" 
src="https://cloud.githubusercontent.com/assets/1630096/11761243/9b8dd0dc-a0ba-11e5-9e6f-d59fcfca23b0.png";>
    
    And gone:
    <img width="1012" alt="screen shot 2015-12-12 at 10 18 29" 
src="https://cloud.githubusercontent.com/assets/1630096/11761244/a3cb0e04-a0ba-11e5-9c74-24c6d2cc6bc6.png";>
    
    Thanks for the fix @ustcweizhou !
    
    Pinging @DaanHoogland @bhaisaab @wilderrodrigues to do a second review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to