Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/859#discussion_r47435639
  
    --- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
    @@ -125,6 +125,25 @@ public UsageVO(Long zoneId, Long accountId, Long 
domainId, String description, S
             this.endDate = endDate;
         }
     
    +    //Network Offering Usage
    +    public UsageVO(Long zoneId, Long accountId, Long domainId, String 
description, String usageDisplay, int usageType, Double rawUsage, Long vmId,
    +                   Long offeringId, Long usageId, Long networkId, Date 
startDate, Date endDate) {
    +        this.zoneId = zoneId;
    +        this.accountId = accountId;
    +        this.domainId = domainId;
    +        this.description = description;
    +        this.usageDisplay = usageDisplay;
    +        this.usageType = usageType;
    +        this.rawUsage = rawUsage;
    +        this.vmInstanceId = vmId;
    +        this.offeringId = offeringId;
    +        this.usageId = usageId;
    +        this.startDate = startDate;
    +        this.endDate = endDate;
    +        this.networkId = networkId;
    +    }
    +
    +
         public UsageVO(Long zoneId, Long accountId, Long domainId, String 
description, String usageDisplay, int usageType, Double rawUsage, Long vmId, 
String vmName,
    --- End diff --
    
    Isn't it possible to extends this one instead of creating a new 
constructor? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to