Github user ustcweizhou commented on the pull request:

    https://github.com/apache/cloudstack/pull/1198#issuecomment-164199095
  
    @DaanHoogland @wilderrodrigues 
    assume there are two routers now routerA (master) and routerB (backup).
    if  we destroy routerA (master) at first, then routerB will become master 
without downtime. and another routerC will create as BACKUP. However, we need 
to destroy routerB as well, then routerC will become MASTER and another new 
routerD will become BACKUP.
    
    in this processing, we also need to wait some seconds for 
keepalived/conntrackd on routerC to be up , because we should make sure that 
the services on BACKUP are running before destroying MASTER.
    
    hence, I think the solution in PR is good (there is only one BACKUP->MASTER 
state change).
    
    for the sleep or not, we need to test it. I added it because the test 
failedout in my testing (without sleep).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to