Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-164401512 @remibergsma rebase with latest master 7c83e1b2402db9e359fb086b158d65c25309a70e result of squashing the commits: (before suqash, 16 commits) pick 8a523e8 [VM-SNAPSHOT] vm snapshot implementation for KVM pick 7e26816 [VM-SNAPSHOT] restoreVMSnapshot from qcow2 image pick 5a369d0 [VM-SHAPSHOT] remove vm snapshots when revert snapshot pick a0fe12f [VM-SNAPSHOT] create volume snapshot from vm snapshot pick 222746f [VM-SNAPSHOT] change icon for revertToVMSnapshot pick b555c5f [VM-SNAPSHOT] fix NPE when start instance with vm snapshots pick f5be57f [VM-SNAPSHOT] restore VM snapshot if migration fails pick a7eb563 [VM-SNAPSHOT] move message for create vm snapshot pick d9853f9 [VM-SNAPSHOT] fix NPE in createSnapshotFromVMSnapshot if vm snapshot does not exist pick 4b8dc8a [VM-SNAPSHOT] use libvirt-java flags instead of virsh command line pick e3bc928 [VM-SNAPSHOT] make small changes (checkAccess, since version, possible NPE, uuid in error message) pick c8c4a4f [VM-SNAPSHOT] take snapshot of specific volume from vm snapshot pick 5e97629 [VM-SNAPSHOT] add unit test for backupSnapshotFromVMSnapshot pick dd881fe [VM-SNAPSHOT] some UI changes pick b976eb3 [VM-SNAPSHOT] sort snapshots by name so that they can be restored by time pick 1047735 [VM-SNAPSHOT] move generation of VMSnapshot XML to LibvirtUtilitiesHelper (after squash, 4 commits) pick 357bc1c [VM-SNAPSHOT] vm snapshot implementation for KVM pick d2d4464 [VM-SNAPSHOT] restoreVMSnapshot from qcow2 image pick cb04506 [VM-SNAPSHOT] create volume snapshot from vm snapshot pick 7e11556 [VM-SNAPSHOT] use libvirt-java flags instead of virsh command line (no diff) [root@weizhou-centos master(vm-snapshot)]# git diff 1047735 [root@weizhou-centos master(vm-snapshot)]#
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---