Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164471811
@Wilderrodrigues, @borisroman I agree with you that we cannot merge PRs
without two(2) LGTMs and integration tests to check if nothing was broken.
@DaanHoogland should have not merged this PR without the second LGTM. However,
before he had merged it, I reviewed the PR but have not given LGTM because
normally these simple PRs a lot of folks appear to give LGTM, my bad for that.
Additionally, I got lost when I checked the right way to include the Apache
license, I notice in same classes we use /** * * **/ blocks, in others we use
//, while thinking about it something else called my attention and I forgot to
give the LGTM.
Before, throwing some stones, I would first check why PR #1196 was merged
without the Apache license. I noticed LGTMs there; maybe they were giving
without proper review? So, here comes a question, should we revert this one
that fixes a build that was broken by #1196, or should we revert the #1196 and
fix it before merging it again? Or we can let it go and learn the lesson that
should not be repeated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
