GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1262
Removed unnecessary code from getGuestOsType in CitrixResourceBase
Considering that all mapping of Guest OS Names to their respective
hypervisor compatible types is made thorugh accessing a database, we've decided
to remove a bit of code in the XcpOssResource class which was doing that same
thing for 2 different OS's (both of which ARE in the database). That has led us
to a bunch of unused parameters in the getGuestOsType method from its
superclass, which we've also decided to remove. Test cases were added for four
different possibilities for the platformEmulator String: one for a null String,
one for a blank String, one for an empy String and one for a random case with a
valid String.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack
lrg-cs-hackday-015
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1262
----
commit 0e97ca62190caebcc12cf2f889aeb2ebd950fd34
Author: cirstofolini <[email protected]>
Date: 2015-12-19T18:42:52Z
Removed unnecessary code from getGuestOsType in CitrixResourceBase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
