Will add some validations On Fri, Jan 8, 2016 at 7:51 PM, DaanHoogland <g...@git.apache.org> wrote:
> Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/1316#issuecomment-170016433 > > test succeeds as is : > ``` > [root@daans-dev-machinina ~]# ssh cs1 nosetests --with-marvin > --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2.cfg -s -a > tags=advanced,required_hardware=true > /data/git/cs1/cloudstack/test/integration/component/maint/test_vpc.py > root@cs1's password: > > ==== Marvin Init Started ==== > > === Marvin Parse Config Successful === > > === Marvin Setting TestData Successful=== > > ==== Log Folder Path: /tmp//MarvinLogs//Jan_08_2016_14_17_12_EBMCRT. > All logs will be available here ==== > > === Marvin Init Logging Successful=== > > ==== Marvin Init Successful ==== > ===final results are now copied to: /tmp//MarvinLogs/test_vpc_1F4ULR=== > ``` > > LGTM but seems less useful due to my remark on line 354 > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
