[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[remibergsma]

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1301#issuecomment-170225209
  
    LGTM
    
    Before this PR, the nr of ip adresses was shown correctly:
    
    <img width="374" alt="cloudstack_pr1301_1" 
src="https://cloud.githubusercontent.com/assets/1630096/12215672/4b4c9716-b6c7-11e5-8901-aabac3afbb9d.png";>
    
    Clicking on an ip address didn't work however:
    
    <img width="1030" alt="cloudstack_pr1301_2" 
src="https://cloud.githubusercontent.com/assets/1630096/12215673/523eb6c6-b6c7-11e5-9531-360b654ec3ba.png";>
    
    In this PR it works for both user/admin and root admin:
    
    <img width="1283" alt="cloudstack_pr1301_3" 
src="https://cloud.githubusercontent.com/assets/1630096/12215674/596af0fe-b6c7-11e5-9cd7-ae2b2640bf35.png";>
    
    <img width="1331" alt="cloudstack_pr1301_4" 
src="https://cloud.githubusercontent.com/assets/1630096/12215678/6e5b2434-b6c7-11e5-871a-5a15a52c098c.png";>
    
    Thanks @nitin-maharana !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---