Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1277#issuecomment-170236373
  
    @koushik-das 
    
    You will have to run the tests on your environment. How did you check that 
the Network GC was running every 10 seconds? After removing the commit with my 
changes the tests are now failing.
    
    In order to hold your -1 you will have to run the tests and prove they are 
working fine.
    
    ```
    Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
FAILED ===
    FAIL
    Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : FAILED ===
    FAIL
    ```
    
    I will put my commit back and rerun the tests.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to