Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r49888184
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83 @@ protected Answer copyFromNfsToS3(CopyCommand cmd) {
}
}
+ protected boolean swiftUploadMetadataFile(SwiftTO swift, File srcFile,
String containerName) throws IOException {
+
+
+ //create a template.properties for Swift with its correct unique
name
--- End diff --
Since you went through the trouble of cleaning up some of the code, how
about you improve it some more by turning this comment into a javadoc comment
for this method, also describing the parameters involved.
If you like this idea, I'd suggest going ahead and writing another javadoc
comment for the `copyFromNfsToSwift` method.
Little things like these can go a long way to improve code readability. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
