GitHub user wilderrodrigues reopened a pull request:
https://github.com/apache/cloudstack/pull/1277
[4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and
CLOUDSTACK-9188
This PR applies the same fixes as in the PR #1259, but against branch 4.7.
Please refer to PR #1259 for the tests results and all the comments already
made there.
Issues fixed are:
* CLOUDSTACK-9154: rVPC doesn't recover from cleaning up of network garbage
collector
* CLOUDSTACK-9187: rVPC routers in Master/Master due to concurrency problem
when writing the keepalivd.conf
* CLOUDSTACK-9188: NetworkGarbageCollector is not using gc.interval and
gc.wait from settings
Those changes have been covered by 2 new tests added to
```smoke/test_vpc_redundant.py```:
* test_04_rvpc_network_garbage_collector_nics
* test_05_rvpc_multi_tiers
The test ```test_04_rvpc_network_garbage_collector_nics``` depends on the
global settings for the network.gc.interval and gc.wait. If one wants the test
to run quicker, please change the settings (default is 600 seconds for each)
and restart the Management Server before running the tests. I would suggest to
set it to 60 seconds.
In addition, the NetworkGarbageCollector was redefining the settings above
mentioned and not reading their values through ConfigDao. Due to that, the
settings were not being applied properly and the test was waiting to long to
check the VPC routers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack
fix/4.7-rvpc-net-gc-CLOUDSTACK-9154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1277
----
commit 7988f51ac07782ad9b9873c32438fd7cdb24edba
Author: Wilder Rodrigues <[email protected]>
Date: 2015-12-17T13:20:59Z
CLOUDSTACK-9154 - Returns the guest iterface that is marked as added
- Force a restart of keepalived if conntrackd is not running or
configuration has changed
commit 749ac2e2242d8af9f05977951dd1b4855c1f6f08
Author: Wilder Rodrigues <[email protected]>
Date: 2015-12-18T09:37:13Z
CLOUDSTACK-9154 - Adds test to cover nics state after GC
commit b1e421068280fe0acc427baf3e9f07dd2d610803
Author: Wilder Rodrigues <[email protected]>
Date: 2015-12-18T17:32:29Z
CLOUDSTACK-9187 - Adds test to cover multiple nics and nic removal
commit c99d6f18c9fccdc44698a30af1b20701a2e85df4
Author: Wilder Rodrigues <[email protected]>
Date: 2015-12-18T17:36:02Z
CLOUDSTACK-9187 - Fixes interface allocation to VRRP instances
commit 3e1cc4ecef716670a9c8953c791189b22d5c9a9e
Author: Wilder Rodrigues <[email protected]>
Date: 2016-01-08T08:22:55Z
CLOUDSTACK-9188 - Formatting the code
commit 638a818a5a6de6cabd2daa8f17325e9475ca0c81
Author: Wilder Rodrigues <[email protected]>
Date: 2016-01-09T09:41:34Z
CLOUDSTACK-9187 - Makes code ready for more something like ethXXXX, if we
ever get that far
commit 6c7ef4b713855002f5ba7a675a315f2723bbf680
Author: Wilder Rodrigues <[email protected]>
Date: 2016-01-09T09:41:50Z
CLOUDSTACK-9154 - Sets the pub interface down when all guest nets are gone
- Refactors the set_backup, set_master and set_fault methods to have
better names for the variable
- Increase the sleep on the test in order to wait for the routers to be
ready. It's now 3 times the GC settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
