GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/1358

    CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains items

    This PR fixes the issue when trying to delete ACL lists which contain item. 
    
    It seemed it was not thought of when the ACS project started, when most 
user were relying on the UI to execute those tasks. Nowadays, with automation 
all over the place and ACL lists containing hundreds of items, it's very hard 
to have to delete them 1 by 1 either via the UI. Writing scripts to do so might 
be a solution, but it would be much simpler to just delete non-attached ACLs 
with all its items in one go.
    
    Also, destroying a VPC that contains ACL lists was "succeeding", but after 
that the ACL list/items were messing up:
    
    ```
    list networkacls aclid=920d74b6-4d15-454f-b3a6-61e7a6ffd1a4
    Error 431: Unable to find VPC associated with acl
    {
      "cserrorcode": 4350,
      "errorcode": 431,
      "errortext": "Unable to find VPC associated with acl",
      "uuidList": []
    }
    ```
    
    So, it also cleans up ACLs when destroying VPCs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ekholabs/cloudstack 
fix/4.7-acl-delete-CLOUDSTACK-9245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1358
    
----
commit 7b106db4b20c457c367a0ab31ca0f984b2d9f752
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date:   2016-01-21T14:51:30Z

    CLOUDSTACK-9245 - Formatting NetworkACLManagerImpl class

commit 84e89a58430897e63de773c0100481694986b3c1
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date:   2016-01-21T14:51:55Z

    CLOUDSTACK-9245 - Formatting VpcManagerImpl class

commit 1571e01994a7d459aa1b123d90cc1418e0ab2037
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date:   2016-01-21T14:52:53Z

    CLOUDSTACK-9245 - Formatting NetworkACLServiceImpl class

commit 81aeb4f4c7eeb6c9ffcebc82d82dc901d7f5c70c
Author: Wilder Rodrigues <wrodrig...@schubergphilis.com>
Date:   2016-01-21T15:16:11Z

    CLOUDSTACK-9245 - Deletes ACL items when destroying the VPC or deleting the 
ACL itself

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to